Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable book search endpoints (fix #472) #816

Merged
merged 3 commits into from Jun 26, 2017

Conversation

@connerbw
Copy link
Member

commented Jun 26, 2017

No description provided.

connerbw added 3 commits Jun 26, 2017
Remove unnecessary isset()
`!empty()` is the same as `isset($foo) && $foo`, but doesn't throw warnings if the variable doesn't exist.

@greatislander greatislander modified the milestone: 4.0 Jun 26, 2017

@greatislander greatislander self-assigned this Jun 26, 2017

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2017

Codecov Report

Merging #816 into dev will decrease coverage by 0.04%.
The diff coverage is 2.22%.

@@             Coverage Diff              @@
##                dev     #816      +/-   ##
============================================
- Coverage     28.83%   28.79%   -0.05%     
+ Complexity     2668     2656      -12     
============================================
  Files            76       76              
  Lines         13638    13659      +21     
============================================
  Hits           3933     3933              
- Misses         9705     9726      +21

@connerbw connerbw requested a review from greatislander Jun 26, 2017

@greatislander greatislander merged commit 234df12 into dev Jun 26, 2017

1 of 3 checks passed

codecov/patch 2.22% of diff hit (target 28.83%)
Details
codecov/project 28.79% (-0.05%) compared to 822f034
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the api-settings branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.