Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select all capability to organize page (fix #249) #822

Merged
merged 2 commits into from Jun 29, 2017

Conversation

@greatislander
Copy link
Collaborator

commented Jun 29, 2017

No description provided.

@greatislander greatislander added this to the 4.0 milestone Jun 29, 2017

@greatislander greatislander self-assigned this Jun 29, 2017

@greatislander greatislander requested a review from connerbw Jun 29, 2017

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 29, 2017

Props @connerbw! FYI, @pbstudent, this fixes an old issue you opened (#249).

@connerbw
Copy link
Member

left a comment

Nice!

@codecov

This comment has been minimized.

Copy link

commented Jun 29, 2017

Codecov Report

Merging #822 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #822   +/-   ##
=========================================
  Coverage     29.95%   29.95%           
  Complexity     2697     2697           
=========================================
  Files            77       77           
  Lines         14004    14004           
=========================================
  Hits           4195     4195           
  Misses         9809     9809

@greatislander greatislander merged commit 63d7132 into dev Jun 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the select-all branch Jun 29, 2017

@SteelWagstaff

This comment has been minimized.

Copy link
Member

commented Jan 8, 2018

I'm not great at reading these status pages and so am a little confused as to the status of the 'select all' feature on the PB organize page. It looks like some exciting progress has been made on this request though. Is this something that will be released as part of the forthcoming 5.0 release or is it already available somewhere but I'm just not finding it, or is it still a future goal?

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2018

It’s there, just not the most usable. It will be improved in Pressbooks 5 as we make some other changes to accomodate the new post statii.

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2018

(Right now tapping/clicking Export/Private/Show Title headers will toggle status for all items in that group. Not very discoverable.)

@SteelWagstaff

This comment has been minimized.

Copy link
Member

commented Jan 8, 2018

Woah! Not discoverable, but still very powerful. I had no idea. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.