Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editors to modify theme options and custom CSS (fix #862) #863

Merged
merged 1 commit into from Jul 25, 2017

Conversation

@greatislander
Copy link
Collaborator

commented Jul 25, 2017

In a conversation today, we identified that users who should not have Administrator privileges on a book are often given them just so they can adjust theme options/edit custom CSS. This PR allows users with Editor privileges to do these things.

@greatislander greatislander added this to the 4.1 milestone Jul 25, 2017

@greatislander greatislander requested a review from connerbw Jul 25, 2017

@connerbw
Copy link
Member

left a comment

Reviewed.

@greatislander greatislander merged commit ad968f9 into dev Jul 25, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@greatislander greatislander deleted the theme-permissions branch Jul 25, 2017

@codecov

This comment has been minimized.

Copy link

commented Jul 25, 2017

Codecov Report

Merging #863 into dev will decrease coverage by <.01%.
The diff coverage is 46.15%.

@@             Coverage Diff              @@
##                dev     #863      +/-   ##
============================================
- Coverage     29.52%   29.51%   -0.01%     
- Complexity     2733     2734       +1     
============================================
  Files            79       79              
  Lines         17071    17075       +4     
============================================
  Hits           5040     5040              
- Misses        12031    12035       +4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.