Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute full-size images in print PDF exports (fixes #894) #898

Merged
merged 8 commits into from Aug 23, 2017

Conversation

@connerbw
Copy link
Member

commented Aug 23, 2017

No description provided.

@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2017

Codecov Report

Merging #898 into dev will increase coverage by 0.35%.
The diff coverage is 53.6%.

@@             Coverage Diff              @@
##                dev     #898      +/-   ##
============================================
+ Coverage     31.02%   31.37%   +0.35%     
+ Complexity     2879     2872       -7     
============================================
  Files            82       82              
  Lines         17822    17886      +64     
============================================
+ Hits           5529     5612      +83     
+ Misses        12293    12274      -19

@greatislander greatislander self-requested a review Aug 23, 2017

@greatislander greatislander added this to the 4.2 milestone Aug 23, 2017

@greatislander
Copy link
Collaborator

left a comment

Awesome!

@greatislander greatislander merged commit a4a23a4 into dev Aug 23, 2017

3 checks passed

codecov/patch 53.6% of diff hit (target 31.02%)
Details
codecov/project 31.37% (+0.35%) compared to 8596c2f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the fullsize-images-in-pdf branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.