Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5 minute time limit to Cloner, coding standards (fixes #903) #904

Merged
merged 1 commit into from Aug 26, 2017

Conversation

@connerbw
Copy link
Member

commented Aug 25, 2017

@bdolor Does this fix the issue for you?

@connerbw connerbw requested a review from greatislander Aug 25, 2017

@bdolor

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2017

Changed max_execution_time back to default value of 30 — this fix works.

@codecov

This comment has been minimized.

Copy link

commented Aug 25, 2017

Codecov Report

Merging #904 into dev will decrease coverage by <.01%.
The diff coverage is 20%.

@@             Coverage Diff              @@
##                dev     #904      +/-   ##
============================================
- Coverage     41.34%   41.33%   -0.01%     
+ Complexity     2865     2864       -1     
============================================
  Files            82       82              
  Lines         17641    17640       -1     
============================================
- Hits           7293     7291       -2     
- Misses        10348    10349       +1

@greatislander greatislander merged commit 4bc573a into dev Aug 26, 2017

1 of 3 checks passed

codecov/patch 20% of diff hit (target 41.34%)
Details
codecov/project 41.33% (-0.01%) compared to aa466c9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the set-timeout branch Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.