New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hooks, deprecate old versions #926

Merged
merged 7 commits into from Sep 8, 2017

Conversation

Projects
None yet
2 participants
@greatislander
Member

greatislander commented Sep 7, 2017

Our coding standards say that actions and filters should start with pb_. A few of them don't. This PR marks the old hooks as deprecated and adds new hooks that are properly named. Related to pressbooks/pressbooks-aldine#7.

Filters:

  • pressbooks_login_color_scheme
  • pressbooks_login_logo
  • pressbooks_publish_page
  • pressbooks_remote_get_retry_response_codes
  • pressbooks_remote_get_retry_wait_time
  • pressbooks_session_configuration

Actions:

  • pressbooks_new_blog
  • pressbooks_top_of_export_page
  • pressbooks_loaded

@greatislander greatislander added this to the 4.3 milestone Sep 7, 2017

@greatislander greatislander requested a review from connerbw Sep 7, 2017

@connerbw

Inception filter. Neat. 👍

greatislander added some commits Sep 7, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 8, 2017

Codecov Report

Merging #926 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                dev     #926      +/-   ##
============================================
+ Coverage     47.53%   47.57%   +0.03%     
- Complexity     2965     2967       +2     
============================================
  Files            82       82              
  Lines         17475    17497      +22     
============================================
+ Hits           8307     8324      +17     
- Misses         9168     9173       +5

codecov bot commented Sep 8, 2017

Codecov Report

Merging #926 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                dev     #926      +/-   ##
============================================
+ Coverage     47.53%   47.57%   +0.03%     
- Complexity     2965     2967       +2     
============================================
  Files            82       82              
  Lines         17475    17497      +22     
============================================
+ Hits           8307     8324      +17     
- Misses         9168     9173       +5

@greatislander greatislander merged commit 525f3d3 into dev Sep 8, 2017

3 checks passed

codecov/patch 100% of diff hit (target 47.53%)
Details
codecov/project 47.57% (+0.03%) compared to 72e9165
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the consistent-hooks branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment