Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set viewportMargin to 5000. (fixes #940) #941

Merged
merged 1 commit into from Sep 12, 2017

Conversation

@connerbw
Copy link
Member

commented Sep 12, 2017

The built-in browser search can be used if we increase viewportMargin

We can set that property to Infinity but I'm going to arbitrarily select the number 5000 in the hopes it helps performance. Our transpiled CSS files are never bigger than ~3000 lines

Let's try that first, use the search plugin when it comes with WP core?

@see codemirror/CodeMirror#4491

@connerbw connerbw requested a review from greatislander Sep 12, 2017

@codecov

This comment has been minimized.

Copy link

commented Sep 12, 2017

Codecov Report

Merging #941 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #941   +/-   ##
=========================================
  Coverage     47.74%   47.74%           
  Complexity     2972     2972           
=========================================
  Files            82       82           
  Lines         17609    17609           
=========================================
  Hits           8407     8407           
  Misses         9202     9202

@greatislander greatislander merged commit 4b0a258 into dev Sep 12, 2017

3 checks passed

codecov/patch Coverage not affected when comparing c4b7e7b...5acf1d3
Details
codecov/project 47.74% remains the same compared to c4b7e7b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the codemirror-search branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.