New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image class fix (fixes #920) #949

Merged
merged 3 commits into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@connerbw
Member

connerbw commented Sep 18, 2017

No description provided.

@greatislander

I'd like to start consistently adding @since to new functions and methods. Otherwise looks great.

@@ -946,6 +935,43 @@ protected function fetchAndSaveUniqueImage( $url ) {
}
/**
* @param int $attachment_id

This comment has been minimized.

@greatislander

greatislander Sep 18, 2017

Member

Can you add @since 4.4.0 here?

@greatislander

greatislander Sep 18, 2017

Member

Can you add @since 4.4.0 here?

This comment has been minimized.

@connerbw

connerbw Sep 18, 2017

Member

This is a protected function.

Noted for public functions.

@connerbw

connerbw Sep 18, 2017

Member

This is a protected function.

Noted for public functions.

@@ -658,4 +648,46 @@ protected function fetchAndSaveUniqueImage( $url ) {
return $pid;
}
/**
* @param int $attachment_id

This comment has been minimized.

@greatislander

greatislander Sep 18, 2017

Member

Can you add @since 4.4.0 here?

@greatislander

greatislander Sep 18, 2017

Member

Can you add @since 4.4.0 here?

@greatislander greatislander added this to the 4.4 milestone Sep 18, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 18, 2017

Codecov Report

Merging #949 into dev will decrease coverage by 0.07%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #949      +/-   ##
============================================
- Coverage     47.74%   47.66%   -0.08%     
- Complexity     2973     2985      +12     
============================================
  Files            82       82              
  Lines         17618    17647      +29     
============================================
  Hits           8411     8411              
- Misses         9207     9236      +29

codecov bot commented Sep 18, 2017

Codecov Report

Merging #949 into dev will decrease coverage by 0.07%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #949      +/-   ##
============================================
- Coverage     47.74%   47.66%   -0.08%     
- Complexity     2973     2985      +12     
============================================
  Files            82       82              
  Lines         17618    17647      +29     
============================================
  Hits           8411     8411              
- Misses         9207     9236      +29

@greatislander greatislander self-requested a review Sep 18, 2017

@greatislander greatislander merged commit 14c4625 into dev Sep 18, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 47.74%)
Details
codecov/project 47.66% (-0.08%) compared to d646799
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@connerbw connerbw deleted the image-class-fix branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment