New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter hook to allow users to brand the catalog page #961

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
2 participants
@monkecheese
Contributor

monkecheese commented Oct 5, 2017

Instead of making the title 'Pressbooks' on the catalog static, users have the option to change it to reflect their needs.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 5, 2017

Codecov Report

Merging #961 into dev will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##               dev     #961      +/-   ##
===========================================
- Coverage     47.8%   47.73%   -0.08%     
- Complexity    2986     2987       +1     
===========================================
  Files           83       83              
  Lines        17595    17701     +106     
===========================================
+ Hits          8412     8449      +37     
- Misses        9183     9252      +69

codecov bot commented Oct 5, 2017

Codecov Report

Merging #961 into dev will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##               dev     #961      +/-   ##
===========================================
- Coverage     47.8%   47.73%   -0.08%     
- Complexity    2986     2987       +1     
===========================================
  Files           83       83              
  Lines        17595    17701     +106     
===========================================
+ Hits          8412     8449      +37     
- Misses        9183     9252      +69

@greatislander greatislander self-requested a review Oct 5, 2017

@greatislander

greatislander requested changes Oct 5, 2017 edited

Hi @monkecheese, can you document this filter hook? Thanks! Make it @since 4.3.4 and I'll adjust if needed.

Add filter hook to allow users to brand the catalog page
Instead of making the title 'Pressbooks'on the catalog, users
have the option to change it to reflect their needs.
@monkecheese

This comment has been minimized.

Show comment
Hide comment
@monkecheese

monkecheese Oct 5, 2017

Contributor

Done.

Contributor

monkecheese commented Oct 5, 2017

Done.

@greatislander greatislander merged commit e2ade6d into pressbooks:dev Oct 10, 2017

2 of 3 checks passed

codecov/project 47.73% (-0.08%) compared to 83549f9
Details
codecov/patch Coverage not affected when comparing 83549f9...b38d435
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment