New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SCSS variables based on options in compiler (fixes #782) #963

Merged
merged 3 commits into from Oct 10, 2017

Conversation

Projects
None yet
2 participants
@connerbw
Member

connerbw commented Oct 6, 2017

No description provided.

@connerbw connerbw requested a review from greatislander Oct 6, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 6, 2017

Codecov Report

Merging #963 into dev will increase coverage by 0.19%.
The diff coverage is 24.62%.

@@            Coverage Diff             @@
##               dev    #963      +/-   ##
==========================================
+ Coverage     47.8%     48%   +0.19%     
- Complexity    2986    2989       +3     
==========================================
  Files           83      83              
  Lines        17595   17743     +148     
==========================================
+ Hits          8412    8517     +105     
- Misses        9183    9226      +43

codecov bot commented Oct 6, 2017

Codecov Report

Merging #963 into dev will increase coverage by 0.19%.
The diff coverage is 24.62%.

@@            Coverage Diff             @@
##               dev    #963      +/-   ##
==========================================
+ Coverage     47.8%     48%   +0.19%     
- Complexity    2986    2989       +3     
==========================================
  Files           83      83              
  Lines        17595   17743     +148     
==========================================
+ Hits          8412    8517     +105     
- Misses        9183    9226      +43

connerbw added some commits Oct 6, 2017

@greatislander

Looks great.

@greatislander greatislander merged commit 96cab55 into dev Oct 10, 2017

2 of 3 checks passed

codecov/patch 24.62% of diff hit (target 47.8%)
Details
codecov/project 48% (+0.19%) compared to 83549f9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the scss-variables branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment