New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented spine based ordering while importing EPUB file to pressbook. #968

Merged
merged 4 commits into from Oct 13, 2017

Conversation

Projects
None yet
3 participants
@hakkim-pits
Contributor

hakkim-pits commented Oct 12, 2017

We have fixed this issue.We have changed the file" inc/modules/import/epub/class-epub201.php "

#442

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 12, 2017

Codecov Report

Merging #968 into dev will decrease coverage by 0.06%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #968      +/-   ##
============================================
- Coverage     48.02%   47.96%   -0.07%     
- Complexity     2951     2955       +4     
============================================
  Files            84       84              
  Lines         17606    17629      +23     
============================================
  Hits           8455     8455              
- Misses         9151     9174      +23

codecov bot commented Oct 12, 2017

Codecov Report

Merging #968 into dev will decrease coverage by 0.06%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #968      +/-   ##
============================================
- Coverage     48.02%   47.96%   -0.07%     
- Complexity     2951     2955       +4     
============================================
  Files            84       84              
  Lines         17606    17629      +23     
============================================
  Hits           8455     8455              
- Misses         9151     9174      +23
@connerbw

Thanks for this pull request! Much appreciated. Can you fix my change requests?

Show outdated Hide outdated inc/modules/import/epub/class-epub201.php Outdated
Show outdated Hide outdated inc/modules/import/epub/class-epub201.php Outdated
Show outdated Hide outdated inc/modules/import/epub/class-epub201.php Outdated
Show outdated Hide outdated inc/modules/import/epub/class-epub201.php Outdated
@greatislander

Thanks for this! One other minor change in addition to @connerbw's comments.

Show outdated Hide outdated inc/modules/import/epub/class-epub201.php Outdated
visakh.rn

@greatislander greatislander merged commit 78fefe4 into pressbooks:dev Oct 13, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 48.02%)
Details
codecov/project 47.96% (-0.07%) compared to db270a6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment