New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize font size theme option as float, not int #969

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@greatislander
Member

greatislander commented Oct 12, 2017

Currently, PDF theme options only support integers for the body font size option. They should support floats (e.g. 11.5pt). This PR fixes this.

@greatislander greatislander added the bug label Oct 12, 2017

@greatislander greatislander requested a review from connerbw Oct 12, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 12, 2017

Codecov Report

Merging #969 into dev will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##                dev     #969   +/-   ##
=========================================
  Coverage     48.02%   48.02%           
  Complexity     2951     2951           
=========================================
  Files            84       84           
  Lines         17606    17606           
=========================================
  Hits           8455     8455           
  Misses         9151     9151

codecov bot commented Oct 12, 2017

Codecov Report

Merging #969 into dev will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##                dev     #969   +/-   ##
=========================================
  Coverage     48.02%   48.02%           
  Complexity     2951     2951           
=========================================
  Files            84       84           
  Lines         17606    17606           
=========================================
  Hits           8455     8455           
  Misses         9151     9151
@connerbw

Seems fine.

@greatislander greatislander merged commit 4b080dc into dev Oct 12, 2017

3 checks passed

codecov/patch 100% of diff hit (target 48.02%)
Details
codecov/project 48.02% (+0%) compared to db270a6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the font-size branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment