Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `pb_global_components_path` filter #982

Merged
merged 1 commit into from Nov 13, 2017

Conversation

@greatislander
Copy link
Contributor

commented Nov 13, 2017

This lets a book theme override the path to global components to point to its own bundled components library.

@greatislander greatislander added this to the 4.4 milestone Nov 13, 2017
@greatislander greatislander requested a review from connerbw Nov 13, 2017
@codecov

This comment has been minimized.

Copy link

commented Nov 13, 2017

Codecov Report

Merging #982 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                dev     #982      +/-   ##
============================================
- Coverage     48.04%   48.03%   -0.01%     
  Complexity     3011     3011              
============================================
  Files            83       83              
  Lines         17881    17881              
============================================
- Hits           8591     8590       -1     
- Misses         9290     9291       +1
@greatislander greatislander merged commit a25e14a into dev Nov 13, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 48.04%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +51.95% compared to 5302eea
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@greatislander greatislander deleted the path-to-globals branch Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.