New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galleries : the thumbnail should use a larger image size in most of the case #1165

Closed
Nikeo opened this Issue Sep 8, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@Nikeo
Contributor

Nikeo commented Sep 8, 2017

150x150 will look pixelized in most of the cases

https://demo.presscustomizr.com/gallery/

@eri-trabiccolo any simple way to fix this ?

@eri-trabiccolo

This comment has been minimized.

Show comment
Hide comment
@eri-trabiccolo

eri-trabiccolo Sep 8, 2017

Contributor

The thumbnail size it's an user choice.
What we do is to fit the image's width to the grid item's width (design choice), which is defined by the columns (user choice).

Alternatively we could set the width to auto
gallery-img

At that point the "problem" would be the action link placement, and at this point I would rather remove it.

p.s.
consider also that the srcset, when available, is always printed for the galleries. For example in the link
you pasted above I don't see pixelated images because the current srcs loaded are 300x300

Contributor

eri-trabiccolo commented Sep 8, 2017

The thumbnail size it's an user choice.
What we do is to fit the image's width to the grid item's width (design choice), which is defined by the columns (user choice).

Alternatively we could set the width to auto
gallery-img

At that point the "problem" would be the action link placement, and at this point I would rather remove it.

p.s.
consider also that the srcset, when available, is always printed for the galleries. For example in the link
you pasted above I don't see pixelated images because the current srcs loaded are 300x300

@eri-trabiccolo

This comment has been minimized.

Show comment
Hide comment
@eri-trabiccolo

eri-trabiccolo Sep 8, 2017

Contributor

Ah, sorry, of course you can try with a different img size than the one the user chose, maybe tying this to the number of selected columns.
https://github.com/presscustomizr/customizr/blob/dev/core/front/utils/class-content-gallery.php#L40

Contributor

eri-trabiccolo commented Sep 8, 2017

Ah, sorry, of course you can try with a different img size than the one the user chose, maybe tying this to the number of selected columns.
https://github.com/presscustomizr/customizr/blob/dev/core/front/utils/class-content-gallery.php#L40

@Nikeo

This comment has been minimized.

Show comment
Hide comment
@Nikeo

Nikeo Sep 8, 2017

Contributor

thank you for this first feedback, I'll follow up later today.

Contributor

Nikeo commented Sep 8, 2017

thank you for this first feedback, I'll follow up later today.

@Nikeo

This comment has been minimized.

Show comment
Hide comment
@Nikeo

Nikeo Sep 18, 2017

Contributor

technical specification => force the size attribute to a max-width: as a function of the number of columns
use a filter add / remove before and after the gallery

Contributor

Nikeo commented Sep 18, 2017

technical specification => force the size attribute to a max-width: as a function of the number of columns
use a filter add / remove before and after the gallery

@Nikeo

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment