New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ul, ol margins #1183

Closed
Nikeo opened this Issue Sep 23, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Nikeo
Contributor

Nikeo commented Sep 23, 2017

Following this feedback http://presscustomizr.com/release-note-for-customizr-pro-v2-0-9-and-customizr-free-v4-0-8/comment-page-1/#comment-375711

With the option “Modern”, the theme handles bullet point and numbering differently compared with “Classic” and what is considered correct. I.e. with bullet points and numbering, the second and following lines normally indent to the start of the text in line one.

Is the intention with “Modern”, that it refrains from doing so, or will it be adjusted?

This user raise a good point, I would prefer having a left margin ( right for RTL ) on lists, just like here for example : http://docs.presscustomizr.com/article/3-creating-a-slider-with-customizr-wordpress-theme#remove-default-slider
This margin should be applied only for the lists inside a page or post content.
I think we already discussed this point a few monthes ago.

@eri-trabiccolo from your standpoint, would there be any unwanted side effect ( with plugins or smthing else) of modifying the current css rules for ul, ol, which are

ol, ul {
    margin: 0;
    padding: 0;
}

to something like

.entry-content ol, .entry-content ul {
    margin: 0 0 9px 25px;
    padding: 0;
}

To be discussed next monday !

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Sep 27, 2017

I did this using em unit according to the previous style.
Please check if it's fine for you.
The ul/ol relevant part in the following commit
eri-trabiccolo@96a3c26
is the one in
assets/front/scss/0_4_layout/_content.scss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment