New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevdem error on singulars #1194

Closed
eri-trabiccolo opened this Issue Sep 28, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@eri-trabiccolo
Contributor

eri-trabiccolo commented Sep 28, 2017

PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function CZR_prevdem::czr_fn_filter_thumb_src(), 1 passed in /srv/www/wordpress-default/public_html/wp-includes/class-wp-hook.php on line 298 and exactly 6 expected in /srv/www/wordpress-default/public_html/wp-content/themes/customizr/core/class-fire-prevdem.php:151

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Sep 28, 2017

solution:
replace:
https://github.com/presscustomizr/customizr/blob/v4.0.8/core/front/models/content/common/media/class-model-thumbnail.php#L189
with:

               $post_thumbnail['tc_thumb'] = apply_filters( 'czr_thumb_html', get_the_post_thumbnail( $post_id, $this->size ), $requested_size = $this->size, $post_id = $id, $custom_thumb_id = null, $_img_attr = null, $tc_thumb_size = $this->size );

(in a near future the post thumbnail should be get using czr_fn_get_thumbnail_model() too)

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Sep 29, 2017

Are you about to release the free version too? If yes take a look a this issue+solution as it affects the prevdem => wp.org preview too then.

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Sep 29, 2017

No I'll wait for the custom header color to release the free.
Yes thanks for the reminder. I'm on it now !

@Nikeo Nikeo closed this in 192d223 Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment