New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header dark skin : hamburger too dark on hover => becomes almost invisible #1200

Closed
Nikeo opened this Issue Oct 5, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Nikeo
Contributor

Nikeo commented Oct 5, 2017

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Oct 5, 2017

I see,
this is probably due to a change we made a long time ago on the scss $grey_light color variable.

That hover color (which is the same for the cart icon btw) is always $grey_light = 777 hex (it's not derived by the foreground or background color, which is bad).

Anyway when I did the custom header skin stuff I addressed this invariability and set that on hover value to the foreground color (in the header skin css is called primary-color) with an alpha of 0.7 . [ N.B. this is valid only for the custom header skin. ]
Probably 0.7 is too small, 0.6 would be better.

You can test the custom header skin and if you think those values are fine we can apply them to the basic light and dark header skin too.

@Nikeo Nikeo assigned Nikeo and unassigned eri-trabiccolo Oct 9, 2017

@Nikeo Nikeo closed this in aced7b9 Oct 9, 2017

@Nikeo Nikeo added the done label Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment