Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long mobile menu and sticky header issue when scrolling #1331

Closed
eri-trabiccolo opened this issue Dec 13, 2017 · 1 comment

Comments

@eri-trabiccolo
Copy link
Contributor

commented Dec 13, 2017

https://secure.helpscout.net/conversation/485980312/35467?folderId=607709

Basically the collapsing menu max-height of 90vh is too much, in a situation where there's a pretty big tagline some menu items become not accessible at all, as we collapse the menu on scrolling.

We should set this max-height dynamically when the "show" event occurs.

@Nikeo Nikeo added this to the 4.0.14 milestone Dec 20, 2017
eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Dec 20, 2017
the mobile-nav__menu-wrapper

as part of the fix for presscustomizr#1331
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2017

fixed in eri-trabiccolo/customizr-front-js-parts@c8e403c

minor css improvement here:
eri-trabiccolo@e51d897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.