New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated underline not removable in some navigation menus #1363

Closed
Nikeo opened this Issue Jan 8, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@Nikeo
Contributor

Nikeo commented Jan 8, 2018

When unchecking the option "Animated underline effect on link hover" in global settings > Formatting, links, the animated underline is still visible when hovering the menu item ( or when displaying the item context ) in :

  • side menu
  • mobile menu

https://secure.helpscout.net/conversation/500270930/36278?folderId=607547

sans titre

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 8, 2018

It happens only with menu items with children in vertical menus, right?

I would also say that also the current menu items, when that option is disabled, should not be underlined at all. What do you think @Nikeo?

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 8, 2018

I would also say that also the current menu items, when that option is disabled, should not be underlined at all. What do you think @Nikeo?
👍

Yes => no underline when the option is disabled. This includes when hovering, current menu item, current parent menu item (if the case ), etc...

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 8, 2018

It happens only with menu items with children in vertical menus, right?

From what I could test yes, but you'll need to test more edge cases in the horizontal menus I think

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 8, 2018

@eri-trabiccolo this issue is becoming the most urgent in our scheduled dev. see https://github.com/orgs/presscustomizr/projects/2#card-6527768

@Nikeo Nikeo added the dev-scheduled label Jan 8, 2018

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 8, 2018

horizontals are fine

yeah I saw it was the most urgent

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 8, 2018

thanks 👍

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 8, 2018

Hope you had a nice week end by the way !

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 8, 2018

Yeah, I had a nice one (ate a lot :P)

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Jan 8, 2018

Fix: modern - fix animated underline not removable in some navigation…
… menus

fixes presscustomizr#1363
also do not underline current menu item when the underline hover effect
option is disabled

@Nikeo Nikeo closed this in #1365 Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment