Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Font awesome => upgrade to FA5 #1364
This upgrade raises the question of the FA5 licensing.
As wp.org theme author, we must use GPL compatible licenses. CC BY ... licenses don't fall in this category.
This means that we unfortunately won't be authorized to use the fancy and fully backward compatible new svg with .js way.
Which is enough for our need, but not the preferred way to use FA.
The FA team has published a guide here : https://fontawesome.com/how-to-use/upgrading-from-4
But here are the specific part for us
Upgrading the assets
The fa assets will be updated in assets/shared/fonts/fa
Soooo, the integration of FA5 in the Customizr theme is pretty much documented here
I would like to include the sass preprocessing to build our own
Upgrading the html markup
Now it looks like this
We need to update the class name everywhere
We need to make sure we don't miss any previous icon ?
Note : This upgrade will also impact all the other repos
@eri-trabiccolo following the discussion about far or fas, font awesome says that the new default is more fas than fab here : https://fontawesome.com/how-to-use/svg-with-js#styles-and-prefixes
So let's use
Here's the list of the social icons that need the to be prefixed with "fas "
REMOVED ICONS WITH REPLACEMENTS (meaning that we force the replacement)
the above replacements will happen only for the already set socials of course
REMOVED ICONS WITH NO REPLACEMENTS
OTHER VISIBLE CHANGES
You can see there are repetitions, that are mostly due to the missing icons forcing process.
The icon will just be not displayed as you can see in the customizer as you can see above.