New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search form focus #1374

Closed
Nikeo opened this Issue Jan 11, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@Nikeo
Contributor

Nikeo commented Jan 11, 2018

My friend, when you click on the search bar in the PC version, you have to re-click in the field to be able to write.

Will this be automatic (Once I click on search icon, I will be able to start writing without having to re-click in the field) in the pro version?

@eri-trabiccolo said

About the search in desktop.
Not a conflict as far as I can see.
It just doesn't focus the search form input when clicking on the search icon in desktop.

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 11, 2018

@eri-trabiccolo I'm now quoting you man !

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 11, 2018

I will write it in my Bio :P

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 11, 2018

I should add it too :P :P

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 12, 2018

should this be done before fa or not?!

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 12, 2018

ah not. I just updated the column https://github.com/orgs/presscustomizr/projects/2

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 12, 2018

Ok, thanks Nico.
I'm on the fa upgrade then, as its previous task have a PR pushed except for the Ninja form issue that I cannot actually recreate, though I will give it another try.

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 12, 2018

OK.
Leave the Ninja form investigation, and the search form focus aside for the moment.
For the today's release the remaining part is Font Awesome + usual tests.

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 16, 2018

@Nikeo Nikeo closed this Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment