New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The retina php code creates also unwanted (and broken) PDF files retina versions #1387

Closed
eri-trabiccolo opened this Issue Jan 16, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@eri-trabiccolo
Contributor

eri-trabiccolo commented Jan 16, 2018

If you upload A.pdf, it creates 'retina' versions like:
A-{thumb-size}@2x.pdf
A-{thumb-size-2}@2x.pdf
A-{thumb-size-3}@2x.pdf

Consider that WP since 4.7 creates images and thumbs from the pdf like:
A-pdf.jpg
A-pdf-{thumb-size}.jpg
A-pdf-{thumb-size-2}.jpg
A-pdf-{thumb-size-3}.jpg

So we should rather have something like:
A-pdf@2x.jpg
A-pdf-{thumb-size}@2x.jpg
A-pdf-{thumb-size-2}@2x.jpg
A-pdf-{thumb-size-3}@2x.jpg

https://secure.helpscout.net/conversation/505992657/36606?folderId=607709

@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 16, 2018

ok.

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue May 30, 2018

Imp: build/delete retina version of pdf thumbnails
Also improve remove retina images logic
fixes presscustomizr#1387

@Nikeo Nikeo closed this in #1537 May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment