New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox doesn't work for images in the WooCommerce description/short description #1394

Closed
eri-trabiccolo opened this Issue Jan 17, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@eri-trabiccolo
Contributor

eri-trabiccolo commented Jan 17, 2018

  1. when in the description tab, the link wrapping the image (link to the media file) doesn't match the delegated element's selector we use here:
    https://github.com/presscustomizr/customizr-front-js-parts/blob/04569189946e45b1b34ef5e499280ce912397308/_parts_modern/_main_jquery_plugins.part.js#L348
    (this happens only for the Modern style)

  2. when in the short description:

  • the php parsing doesn't occur (as the wc short description, I guess, doesn't apply the the_content filter - same for the Classical style too )
  • even if the php parsing occurred, the js part wouldn't match the link as in 1)
  1. reported here https://secure.helpscout.net/conversation/507324491/36668?folderId=607709
@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 17, 2018

How do you feel about fixing this ?

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 17, 2018

  1. is fast, minor js change
  2. I have to look for the wc filter, shouldn't be long, assuming we want it :D
@Nikeo

This comment has been minimized.

Contributor

Nikeo commented Jan 17, 2018

OK I've placed this one and #1393 WooCommerce related before hueman FA5 upgrade then

@eri-trabiccolo

This comment has been minimized.

Contributor

eri-trabiccolo commented Jan 17, 2018

customizr part in: #1395
customizr-front-js part in: presscustomizr/customizr-front-js-parts#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment