Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How impacting would it be to turn slider .czrs-title from H1 to H2 ? #1489

Open
Nikeo opened this issue Mar 6, 2018 · 4 comments · Fixed by #1490

Comments

@Nikeo
Copy link
Contributor

commented Mar 6, 2018

in https://github.com/presscustomizr/customizr/blob/dev/templates/parts/modules/slider/slide.php#L29

@eri-trabiccolo even if we know that the SEO impact of having several H1 headings in a page is minimal, let's align the slider to the recommend practices.

Any opinion ?

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2018

Well, we might have the opposite complaints :D
"The front page, when displaying a logo, has no h1".

Except for this, I don't see any other problem.

@Nikeo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2018

yeah :)
OK so let's implement it. Can you take care about it ?
The only specification is to make sure that the markup change from H1 to H2 has no visual impact on the font size and Line height. And no impact on javascript ( if any, but I don't think so because we target the class names with fittext ).

@eri-trabiccolo eri-trabiccolo added the 2-ms label Mar 6, 2018

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Mar 6, 2018
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2018

Done, with the CSS changes, doesn't seem to have any impact, tested with wfc too.

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

This change has been requested for the classical style too:
https://wordpress.org/support/topic/class-h1-slide-are-not-good-for-seo-bing-google-ect/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.