Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single post on mobile => huge white space below the featured thumbnail #1524

Closed
Nikeo opened this issue Apr 26, 2018 · 3 comments · Fixed by #1525

Comments

@Nikeo
Copy link
Contributor

commented Apr 26, 2018

schermata_2018-04-22_alle_21 21 00

I have been able to reproduce the problem when emulating an iphone on this page
https://www.anagni5stelle.it/comunicato-stampa-06-2018-22-aprile-certificazione-lista-anagni-5s/

But not reproductible on the demo here for example : https://demo.presscustomizr.com/back-from-a-trip-in-norway/

This seems to be related to the css-centering on the user's website.
@eri-trabiccolo can you investigate on it ?

@Nikeo Nikeo changed the title Single post with => huge white space below the featured thumbnail Single post on mobile => huge white space below the featured thumbnail Apr 26, 2018
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2018

Hi @Nikeo, surely due to the js centering option not enabled.
There's a CSS fallback that should center the image (center, but not cover) in the "container", but it's buggy as far as I can see.
It should look like this:
2018-04-26_10-03-13
(image centered in an element with an height of 400px)
I don't know if that's ideal though...

"The problem" is that the singular thumbnail doesn't scale in mobiles (like the slider does), so that the custom height option set in the customizer is valid for all the devices.

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2018

Same happens in the classical style :/

@Nikeo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

can we quickly chat about it on skype ?

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Apr 26, 2018
smartphones
both in modern and classical style
fixes presscustomizr#1524
@Nikeo Nikeo added the Needs tests label Apr 27, 2018
@Nikeo Nikeo closed this in #1525 May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.