Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with WPForms Stripe Credit Card Input? #1636

Closed
Nikeo opened this issue Nov 30, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@Nikeo
Copy link
Contributor

commented Nov 30, 2018

https://secure.helpscout.net/conversation/720326657/166362/?folderId=607544

Hello. I manage a site for a nonprofit and recently discovered that we are not able to use WPForms to collect credit card information on our site. When you try to input the credit card, the year will not enter. I did a quick check with twenty seven theme and it seems to works fine there (verified with live preview). I verified that this is not a plug-in incompatibility issue (deactivated every plugin). Can you tell me if you have had other reports of this? I've currently had to rework the donation page to eliminate taking credit cards, which is obviously not going to work long-term. Please see this page for a first-hand look at the issue: teamtomball.com/sponsorship All you have to do is scroll to the bottom of the page, input a month and attempt to input a year and you'll see that it doesn't work. Help!? I've used your theme for a year and a half and we all love it. However, we have to be able to take credit card information on our site.

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

well it depends on our CSS rule which sets the select min-width to 100%, which makes the "expiration" selects sit one on top of each other
I can remove it, or, maybe better, override it for wp-forms.

I think I can either replace the min-width with just width and should be fine. I will check the most important plugins with this change.

@eri-trabiccolo eri-trabiccolo self-assigned this Nov 30, 2018

@Nikeo Nikeo added the dev-scheduled label Nov 30, 2018

@eri-trabiccolo eri-trabiccolo added the 2-ms label Nov 30, 2018

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

I went with the width set to 100%, with a minimum code added for WooCommerce.

Anyway the min-width:100% is there since the beginning:
ab37c79#diff-e53151a497ef302df56b04e0bdc1e567R110

@Nikeo

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2018

ok. So it was useful only for WooCommerce then.
Anyway, a potential regression on another plugin is not that risky. We're only talking of a css rule.

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

Yeah, we'll see :)

@Nikeo Nikeo closed this in #1638 Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.