Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.czr__r-w16by9 { @include czr__responsive-wrapper( 16, 9 ); } => breaks video post format #1742

Closed
Nikeo opened this issue Apr 25, 2019 · 10 comments

Comments

@Nikeo
Copy link
Contributor

@Nikeo Nikeo commented Apr 25, 2019

2019-04-25_11-40-10

This can be reproduced when creating post with the video post format.

@eri-trabiccolo any idea why? Can I assign this issue to you ?
Thanks

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented Apr 25, 2019

can you point me to the support request?
Because that might be a plugin conflict.

that's OUR way to have responsive videos for the video post formats only.
see: https://demo.presscustomizr.com/video-post/

there's no bug in that.

To be more clear, the problem is that, on that website, the actual video iframe is wrapped into a div (.wp-video), this happens, I think, because of some plugin filtering the WP embed.

That's my guess...

@Nikeo

This comment has been minimized.

Copy link
Contributor Author

@Nikeo Nikeo commented Apr 25, 2019

No plugins enabled. This is something I discovered on a personal site.

But OK, I think we designed a solution working for vimeo and youtube only.
But it breaks when embedding a self hosted mp4 video or a facebook video.

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented Apr 25, 2019

perfect, I'm on it then.

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Apr 25, 2019
…h self-hosted video files

fixes presscustomizr#1742
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented Apr 25, 2019

Ah wait, didn't test the facebook video thing, how can I?

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented Apr 25, 2019

Ok found it, I'm about to force the previous commit.

@Nikeo

This comment has been minimized.

Copy link
Contributor Author

@Nikeo Nikeo commented Apr 25, 2019

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Apr 25, 2019
when using self-hosted or facebook video URLs
fixes presscustomizr#1742
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented Apr 25, 2019

you're creepy man :P
The latest commit is fine ;)

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented Apr 25, 2019

Naa it's not, doesn't work fine with fb... meaning that the video won't be responsive.
This makes things a little harder, and means that before "wrapping" into a responsive div we might need to know the source.

I close the PR for the moment.

I think we will end up making only wp-video and more standard video embeds (youtube, vimeo) to be responsive, skipping the others.

@eri-trabiccolo eri-trabiccolo removed the fixed label Apr 25, 2019
@Nikeo

This comment has been minimized.

Copy link
Contributor Author

@Nikeo Nikeo commented Apr 25, 2019

I think we will end up making only wp-video and more standard video embeds (youtube, vimeo) to be responsive, skipping the others.

I'm fine with that

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Apr 25, 2019
when using self-hosted or facebook video URLs
we now handle only the responsiveness embeds which are iframes
fixes presscustomizr#1742
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented Apr 25, 2019

Ok, cannot make wp-video responsive, so only videos which are iframes will be responsive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.