Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

czr_fn_isprevdem : potential cache issue #844

Closed
Nikeo opened this issue Mar 12, 2017 · 4 comments

Comments

@Nikeo
Copy link
Contributor

commented Mar 12, 2017

https://wordpress.org/support/topic/website-looks-different-when-viewed-live/#post-8904262

Hello,

I need some Help. I am using the Customizr Theme for my web site. Yesterday I notice that my web site started to change all on its on. The color of the font, pictures, page layout ect. When I log into my account my web page looks like correct. I have tried to republished the site but I am getting the same results. I log into my account and everything looks fine. If I go directly to my site onlinetruevine.org it looks completely different. Can Someone help me fix this problem?

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2017

Not sure Nico,
I don't think from_cache should be a param.
We're never interested in bailing if the value is not cached.
Just a question: when you return alloptions if optname is null...

What's the purpose? To return the alloptions['opt_group'] in that case?
But that would mean that opt_group is not null and or has been found. Otherwise you really might return alloptions as is.

So my question is, is there a case where you're really interested in getting $alloptions?

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2017

what do you think about #846
maybe we can remove the whole true == wp_installing() case and special case like home, siteurl..etc we're not interested in.
That's pretty much a copy of wp get_option but without filters plus "suboption" handling.

@Nikeo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2017

Thanks for your feedbacks !
Let's discuss them on Monday. Enjoy the day of the Lord. ( and I know it means so much for you ... ) ;)

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2017

Yes, thanks for respecting my feelings ;)

@Nikeo Nikeo closed this in 15b13f1 Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.