Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Classic] Various js actions are not being triggered anymore because of the tc-resize event removal #961

Closed
eri-trabiccolo opened this issue Jun 15, 2017 · 0 comments · Fixed by #963

Comments

@eri-trabiccolo
Copy link
Contributor

commented Jun 15, 2017

  1. Logo shrink messy:
    https://wordpress.org/support/topic/logo-banner-messed-up-after-update/
  2. Sidebars reordering
  3. Second menu moving
    (etc.)
    These happen because tc-resize event has been removed in czrapp but we still refer to it in many classic js parts (sticky_header, sidenav and so on).

It should be reintroduced:
https://github.com/presscustomizr/customizr/blob/v3.5.12/inc/assets/js/parts/_main_base.part.js#L105

You see, we use this wrapper, in the classic style js, to store the current_device, and pass params need by some features like 2) and 3)

@eri-trabiccolo eri-trabiccolo added the bug label Jun 15, 2017

@eri-trabiccolo eri-trabiccolo changed the title [Classic]Logo shrink on sticky: when header unsticks it doesn't refresh its size [Classic] Logo: when header unsticks it doesn't refresh its size Jun 15, 2017

@eri-trabiccolo eri-trabiccolo self-assigned this Jun 15, 2017

@eri-trabiccolo eri-trabiccolo changed the title [Classic] Logo: when header unsticks it doesn't refresh its size [Classic] Various js actions are not being triggered anymore because of the tc-resize event removal Jun 15, 2017

eri-trabiccolo added a commit to eri-trabiccolo/customizr that referenced this issue Jun 15, 2017

@Nikeo Nikeo closed this in #963 Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.