Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom portion of Sidebar gets cut off in tablet view when content is short #476

Closed
denzelchia opened this issue May 9, 2017 · 5 comments

Comments

@denzelchia
Copy link

commented May 9, 2017

Hi,

Bottom portion of sidebar gets cut off in tablet view ( 480px to 960px width ) when content is shorter than sidebar.

Please refer to the following forum post for steps to replicate this issue.
https://wordpress.org/support/topic/sidebar-truncated-in-tablet-view-at-short-pages/#post-9107274

Thank you

@Nikeo Nikeo added the enhancement label May 16, 2017
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

@eri-trabiccolo eri-trabiccolo added the bug label Jun 8, 2017
@plimfec

This comment has been minimized.

Copy link

commented Jun 8, 2017

@eri-trabiccolo:
Thank you for labeling this as a bug. I think the initial 'enhancement' label is incorrect, because it really is a serious problem when parts of the content are being cut off by the design. I would even judge this as a showstopper in my own business and wouldn't go live this way.

Hopefully it is repaired soon, thanks for the efforts.

@Nikeo Nikeo added the urgent label Jun 27, 2017
@Nikeo

This comment has been minimized.

Copy link
Collaborator

commented Jun 27, 2017

https://wordpress.org/support/topic/cant-update-from-3-3-7-as-github-476-bug-still-cutting-content/#post-9265352

Wrong height applied to the sidebar.
I think it depends on the fact the sidebar-content has display: none when collapsed (jQuery cannot retrieve its height)
so here:
https://github.com/presscustomizr/hueman/blob/v3.3.13/assets/front/css/dev-responsive.css#L96
https://github.com/presscustomizr/hueman/blob/v3.3.13/assets/front/css/dev-responsive.css#L24

a display:block + visibility: hidden should be fine

@Nikeo Nikeo modified the milestones: 3.3.14, 3.3.16 Jun 27, 2017
@Nikeo

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2017

The steps to provide the issue:
– Open the site and then narrow the screen below 960 px.
– When outlook changes to tablet view, open sidebar with toggle button.
– Scroll to the bottom of the page
– See right and left sidebar truncated
(Second link is showing scribd prentscreens of the issue.)

@Nikeo Nikeo closed this in 41446c1 Oct 3, 2017
@Nikeo Nikeo added the fixed label Oct 3, 2017
Nikeo added a commit that referenced this issue Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.