New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please replace function hu_is_authorized_tmpl with something that checks for file presence #610

Open
answerquest opened this Issue Dec 31, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@answerquest
Contributor

answerquest commented Dec 31, 2017

Referenced in #564 , and I created a pull request #608 (to make it pluggable) as a proposed workaround.

But thinking about this again, this hu_is_authorized_tmpl function doesn't really make much sense. I don't think any other theme does this. Wouldn't it be better to get the php code to simply check for the physical presence of the $tmpl file, and if not found, then default to a known one? That approach would keep the hueman theme flexible to allow any kind of custom post type template etc. (as most themes are, note)

The present approach is just creating more work; we cannot expect admins who don't know php well to do it, and there is nothing mentioned in the documentation of either hueman or wordpress about this when one looks up creating templates for custom post types. I was lucky I followed through each function being called in the template files and came across this, and was lucky to have time at hand for researching this. Had my project been live I would have just dumped this theme and moved on to another one. (Remaining post redacted as the fatal error problem is fixed with #608)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment