Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in headers still don't have image dimensions #790

Closed
Tarun80 opened this issue May 10, 2019 · 3 comments · Fixed by #795
Closed

Images in headers still don't have image dimensions #790

Tarun80 opened this issue May 10, 2019 · 3 comments · Fixed by #795

Comments

@Tarun80
Copy link

@Tarun80 Tarun80 commented May 10, 2019

Previously I had an issue about this very thing. Unfortunately this issue still exists today.

This is still something that is needed and beneficiary when optimizing a website. Even GTMetrix will flag this as an issue.

What can we do to resolve this?

@Tarun80

This comment has been minimized.

Copy link
Author

@Tarun80 Tarun80 commented May 16, 2019

Any word on this?

eri-trabiccolo added a commit to eri-trabiccolo/hueman that referenced this issue May 27, 2019
@Nikeo Nikeo closed this in #795 May 29, 2019
@Tarun80

This comment has been minimized.

Copy link
Author

@Tarun80 Tarun80 commented May 30, 2019

@eri-trabiccolo @Nikeo Thanks for the patch. Unfortunately this has not resolved the issue. GTMetrix will also report that image dimensions are missing.

<p class="site-title">
    <a class="custom-logo-link" href="localhost" rel="home" title="localhost"><img src="localhost/wp-content/uploads/logo.png" alt="Localhost"></a>
</p>

It's still missing the height="##" and width="##"

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented May 30, 2019

Hi @Tarun80 thanks for the feedback.
So that's a different, yet similar, issue, as #300 was about the header image not the logo image.
Opened a new issue about this, see #797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.