Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to control the visibility of featured image in single page #793

Closed
Nikeo opened this issue May 24, 2019 · 3 comments
Closed

Comments

@Nikeo
Copy link
Collaborator

@Nikeo Nikeo commented May 24, 2019

  • option should be located in Main body Design > Single page settings
  • visibility disabled by default

reported https://secure.helpscout.net/conversation/859696497/217351?folderId=607547

@Nikeo Nikeo changed the title Add new option do control the visibility of featured image in single page Add new option to control the visibility of featured image in single page May 27, 2019
eri-trabiccolo added a commit to eri-trabiccolo/hueman that referenced this issue May 27, 2019
@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented May 27, 2019

Done in #794

though... wouldn't be better to handle the default visibility with the hu_started_before_version, considering that the featured image in pages is currently displayed by default?

@Nikeo

This comment has been minimized.

Copy link
Collaborator Author

@Nikeo Nikeo commented May 27, 2019

@eri-trabiccolo thanks for the PR
About the defaut value, I'll communicate about the change in the release note + a quick doc.
Hardcoding the default is not risky and I prefer that users know about this option. In other words, if they don't see the featured image as it was usually, they'll discover that they can now display it or not.

@eri-trabiccolo

This comment has been minimized.

Copy link
Contributor

@eri-trabiccolo eri-trabiccolo commented May 27, 2019

Makes sense, thanks for the explanation :)

@Nikeo Nikeo closed this in #794 May 29, 2019
Nikeo added a commit that referenced this issue May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.