Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #116] Fix an error message for unsupported Supfile version #117

Merged
merged 2 commits into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@mingrammer
Copy link
Contributor

commented Aug 15, 2017

I fixed an error message for unsupported Supfile version for avoiding confused experience

@VojtechVitek
Copy link
Member

left a comment

LGTM. Minor feedback

Thank you for your contribution!

supfile.go Outdated
@@ -213,7 +221,7 @@ func NewSupfile(file string) (*Supfile, error) {
case "0.4", "0.5":

default:
return nil, ErrMustUpdate{"unsupported version " + conf.Version}
return nil, ErrUnsupportedVersion{"unsupported version " + conf.Version}

This comment has been minimized.

Copy link
@VojtechVitek

VojtechVitek Aug 15, 2017

Member

unsupported Supfile version ?

supfile.go Outdated
func (e ErrMustUpdate) Error() string {
return fmt.Sprintf("%v\n\nPlease update sup by `go get -u github.com/pressly/sup/cmd/sup`", e.Msg)
}

func (e ErrUnsupportedVersion) Error() string {
return fmt.Sprintf("%v\n\nCheck your Supfile version (available versions: 0.{1|2|3|4|5})", e.Msg)

This comment has been minimized.

Copy link
@VojtechVitek

VojtechVitek Aug 15, 2017

Member

can we list the latest version only, ie. v0.5?

@mingrammer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2017

Reflected your suggestions!

@VojtechVitek VojtechVitek merged commit 10e872d into pressly:master Aug 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mingrammer mingrammer deleted the mingrammer:fix-error-message branch Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.