Initial contributing guide #84

Merged
merged 3 commits into from Jan 26, 2017

Conversation

4 participants
@avelino
Member

avelino commented Jan 26, 2017

No description provided.

@avelino avelino added this to the 0.1 milestone Jan 26, 2017

@avelino

This comment has been minimized.

Show comment
Hide comment
@avelino

avelino Jan 26, 2017

Member

Team review text please

Member

avelino commented Jan 26, 2017

Team review text please

+- Operating system:
+- Go version:
+- Log gist:
+

This comment has been minimized.

@felipeweb

felipeweb Jan 26, 2017

Member

we can ask for a URL too, because pREST use querystring to build where SQL clause

@felipeweb

felipeweb Jan 26, 2017

Member

we can ask for a URL too, because pREST use querystring to build where SQL clause

CONTRIBUTING.md
+
+## Discuss your design
+
+The project welcomes submissions but please let everyone know what you're working on if you want to change or add something to the pREST repositorie.

This comment has been minimized.

@felipeweb

felipeweb Jan 26, 2017

Member

fix typo to repository

@felipeweb

felipeweb Jan 26, 2017

Member

fix typo to repository

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 26, 2017

Current coverage is 87.69% (diff: 100%)

Merging #84 into master will not change coverage

@@             master        #84   diff @@
==========================================
  Files             8          8          
  Lines           772        772          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            677        677          
  Misses           64         64          
  Partials         31         31          

Powered by Codecov. Last update a2470ff...fa00799

codecov-io commented Jan 26, 2017

Current coverage is 87.69% (diff: 100%)

Merging #84 into master will not change coverage

@@             master        #84   diff @@
==========================================
  Files             8          8          
  Lines           772        772          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            677        677          
  Misses           64         64          
  Partials         31         31          

Powered by Codecov. Last update a2470ff...fa00799

@marioidival

I think we need to create a Coding Conventions, but it's good enough

@avelino avelino merged commit efedec4 into master Jan 26, 2017

4 checks passed

codecov/patch Coverage not affected when comparing a2470ff...fa00799
Details
codecov/project 87.69% (+0.00%) compared to a2470ff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avelino avelino deleted the contribute_guide branch Jan 26, 2017

@avelino

This comment has been minimized.

Show comment
Hide comment
@avelino

avelino Jan 26, 2017

Member

@marioidival create new issue pls

Member

avelino commented Jan 26, 2017

@marioidival create new issue pls

avelino added a commit that referenced this pull request Jan 26, 2017

Merge branch 'master' of github.com:nuveo/prest
* 'master' of github.com:nuveo/prest:
  Add others comparisons in WHERE (#83)
  set topic query operators
  Initial contributing guide (#84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment