Skip to content

use annotations to mark routes for inclusion in the sitemap #12

Closed
tonypiper opened this Issue Apr 5, 2013 · 5 comments

2 participants

@tonypiper

Hello, inspired by https://github.com/dreipunktnull/DpnXmlSitemapBundle I've created a listener that allows you to use annotations to include routes in the Sitemap.

Does this have a place in PrestaSitemapBundle? If so, do you want me to integrate it?

https://gist.github.com/tonypiper/4a89b5c2c60c50c9334f

@iamdey
iamdey commented Apr 5, 2013

Hello, this feature could be great in prestaSitemapBundle and can help developers to quickly create their sitemap.
But how do you think the urls can be decorated ?

@tonypiper

Glad you like it. The envisaged use case was for static site pages (/about, /privacy etc). I can't see how you'd be able to describe anything more complex with an annotation but don't know how many people use the decorators so this might not be a problem for most of us!

@iamdey
iamdey commented Apr 7, 2013

Ok I suppose people who needs advanced sitemap should define their own listeners.
So, could you also provide unit tests for your class and eventually apply checkstyle fixes?

@tonypiper

Here you go, David. I've enabled it by default - is that OK? Let me know and I'll write some docs too.

@iamdey
iamdey commented Apr 9, 2013

Following the conversation on #13

@iamdey iamdey closed this Apr 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.