Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Symfony 4.x deprecations #184

Merged
merged 6 commits into from Sep 26, 2019

Conversation

@ostrolucky
Copy link
Contributor

ostrolucky commented Apr 1, 2019

Didn't require too much more changes after yours. Basic was to get rid of subclassing main Controller. This is kinda BC break in case somebody subclasses controller, but no way around that.

@ostrolucky ostrolucky force-pushed the ostrolucky:sf42 branch from eaec5a6 to 21497df Apr 1, 2019
@ostrolucky ostrolucky changed the base branch from php73-sf42 to master Apr 1, 2019
@ostrolucky ostrolucky force-pushed the ostrolucky:sf42 branch 3 times, most recently from 2dc08d9 to 1f360e6 Apr 1, 2019
@yann-eugone yann-eugone referenced this pull request Apr 2, 2019
@yann-eugone

This comment has been minimized.

Copy link
Member

yann-eugone commented Apr 13, 2019

Hi @ostrolucky . Thank you for this, it will help.
Those that rely on this controller are doing it wrong, but yeah, this is BC.
The only thing that makes me a bit scared is the routing controller syntax, I can't remember if this is something that was introduced in a later version of the Framework.

Anyway, I think it is time for this bundle to drop some versions support, will try to work on this next week, so yes, we will merge this for the next major.

@ostrolucky

This comment has been minimized.

Copy link
Contributor Author

ostrolucky commented Apr 13, 2019

Well tests should cover that and 2.8 is passing

yann-eugone and others added 6 commits Mar 1, 2019
…ed tests
@ostrolucky ostrolucky force-pushed the ostrolucky:sf42 branch from 1f360e6 to 1a5982c Apr 13, 2019
@norkunas

This comment has been minimized.

Copy link
Contributor

norkunas commented Jul 9, 2019

Is there anything more to do? :)

@yann-eugone

This comment has been minimized.

Copy link
Member

yann-eugone commented Jul 9, 2019

This pull request contains BC. We should merge it before next major version.

@norkunas

This comment has been minimized.

Copy link
Contributor

norkunas commented Jul 9, 2019

Yes, the question was meant to be is there anything to do before releasing next major? :)

@yann-eugone

This comment has been minimized.

Copy link
Member

yann-eugone commented Jul 9, 2019

Not sure. I had no plan for that.
Maybe we can end #202 and tag the last minor release.

@yann-eugone yann-eugone merged commit 691e45c into prestaconcept:master Sep 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.