Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Content-Type text/xml header #214

Merged
merged 2 commits into from Oct 20, 2019

Conversation

@fnowacki
Copy link
Contributor

fnowacki commented Oct 17, 2019

Currently, without dumping sitemap, controller response serving text/html Content-Type header. This fix setting up correct header for xml sitemap.

@yann-eugone

This comment has been minimized.

Copy link
Member

yann-eugone commented Oct 18, 2019

Hey ! This is a great catch ! Thank you.

Can you please add some assertions to the associated test ?

@fnowacki

This comment has been minimized.

Copy link
Contributor Author

fnowacki commented Oct 20, 2019

@yann-eugone done :)

@yann-eugone yann-eugone merged commit 7b6ca37 into prestaconcept:master Oct 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yann-eugone

This comment has been minimized.

Copy link
Member

yann-eugone commented Oct 20, 2019

Thank you for this !

@fnowacki fnowacki deleted the fnowacki:patch-1 branch Oct 21, 2019
@fnowacki

This comment has been minimized.

Copy link
Contributor Author

fnowacki commented Oct 21, 2019

@yann-eugone do you plan release fix for current 1.7 version?

@yann-eugone

This comment has been minimized.

Copy link
Member

yann-eugone commented Oct 21, 2019

@fnowacki

This comment has been minimized.

Copy link
Contributor Author

fnowacki commented Oct 21, 2019

I will be grateful :)

yann-eugone added a commit that referenced this pull request Oct 22, 2019
* Add missing Content-Type text/xml header

* #214 Add tests for content-type
yann-eugone added a commit that referenced this pull request Oct 22, 2019
* Add missing Content-Type text/xml header

* #214 Add tests for content-type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.