New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send logging to JUL rather than discarding #34

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@electrum
Contributor

electrum commented Nov 1, 2018

No description provided.

@electrum electrum requested a review from dain Nov 1, 2018

@findepi

This comment has been minimized.

Member

findepi commented Nov 1, 2018

This is basically the same as #33, except this adds runtime scope.

@dain

dain approved these changes Nov 1, 2018

I'm fine with this or #33. You two can decide on which to merge.

@findepi

findepi approved these changes Nov 2, 2018

@findepi findepi referenced this pull request Nov 2, 2018

Closed

Retain logging from Hive #33

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Nov 17, 2018

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment