Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DictionaryBlock#getLogicalSizeInBytes() #14417

Open
yingsu00 opened this issue Apr 21, 2020 · 2 comments
Open

Optimize DictionaryBlock#getLogicalSizeInBytes() #14417

yingsu00 opened this issue Apr 21, 2020 · 2 comments
Assignees
@yingsu00
Labels
aria Presto Aria performance improvements stale

Comments

@yingsu00
Copy link
Contributor

DictionaryBlock#getLogicalSizeInBytes() calls dictionary.getRegionSizeInBytes(position, 1); for each position. This is very slow when the dictionary is also a DictionaryBlock. Optimize this will help the OrcWriter, Unnest, and Repartitioning who uses it.
@yingsu00 yingsu00 self-assigned this Apr 21, 2020
@yingsu00 yingsu00 added the aria Presto Aria performance improvements label Apr 21, 2020
@yingsu00
Copy link
Contributor Author

cc @prestodb/aria @biswapesh

@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically marked as stale because it has not had any activity in the last 2 years. If you feel that this issue is important, just comment and the stale tag will be removed; otherwise it will be closed in 7 days. This is an attempt to ensure that our open issues remain valuable and relevant so that we can keep track of what needs to be done and prioritize the right things.

@stale stale bot added the stale label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yingsu00 yingsu00

Labels
aria Presto Aria performance improvements stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yingsu00