Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Report a possible race issue #3647
Hi, Developers of facebook/presto,
I am writing to report a race issue on use of ConcurrentHashMap. The issue is reported by our tool in an automatic way. Although manually confirmed, it would be a false positive, given we do not know the specification of the program. We would very appreciate if you could check below for details and confirm with us whether it is a real problem. For more information, please refer to our website: http://sav.sutd.edu.sg/?page_id=2845
It seems to me that synchronization in BlackHoleMetadata class is not needed at all. Even if all accesses to
To avoid that we would need add synchronization mechanisms in *Task classes (e.g. CreateTableTask) or even higher in DataDefinitionExecution.
The downside of that is that ConnectorMetadata interface would probably become much less user friendly.
Simple approach of fixing that would be to try implement transaction-like
What do you think about it?