Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hit/miss metrics for compiled code caches #7081

Closed
martint opened this issue Jan 14, 2017 · 6 comments
Closed

Add hit/miss metrics for compiled code caches #7081

martint opened this issue Jan 14, 2017 · 6 comments

Comments

@martint
Copy link
Contributor

martint commented Jan 14, 2017

I suspect that the caches for compiled code are not very effective for large, varied workloads. We should add cache hit/miss metrics and expose them via JMX to be able to test this hypothesis.

Classes that need to be instrumented: ExpressionCompiler, JoinCompiler, JoinFilterFunctionCompiler, JoinProbeCompiler, OrderingCompiler

@raghavsethi
Copy link
Contributor

Merged this.

@martint
Copy link
Contributor Author

martint commented Feb 4, 2017

Only ExpressionCompiler is implemented.

@martint martint reopened this Feb 4, 2017
@nezihyigitbasi
Copy link
Contributor

Is anyone working on this issue? Otherwise I will go for it.

@nezihyigitbasi
Copy link
Contributor

@ebyhr Will you also handle JoinCompiler and JoinProbeCompiler classes, which require some refactoring? I was planning to work on those when I assigned this issue to myself (after I got no response to my ping), so I will be happy to take those if you don't have any plans, otherwise feel free to assign the issue to yourself.

@ebyhr
Copy link
Contributor

ebyhr commented Feb 7, 2017

Sorry @nezihyigitbasi, I overlooked your ping.
I don't have any plans, so I would be grateful if you deal this :)

@nezihyigitbasi
Copy link
Contributor

Now that #7333 is merged, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants