New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql may fail with distinct columns in having statement #1104

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@chenchun
Copy link
Contributor

chenchun commented Mar 7, 2014

presto:default> select rank, count(distinct cityid) from dim.city group by rank having count(distinct cityid) > 30;
Query 20140305_114830_00009_jvyte failed: Multiple entries with same key: count_1=cityid$distinct and count_1=cityid$distinct
@martint

This comment has been minimized.

Copy link
Collaborator

martint commented Mar 7, 2014

Thanks for the fix! If you haven't done so already, please sign the CLA (https://developers.facebook.com/opensource/cla) so that we can apply the change.

@chenchun

This comment has been minimized.

Copy link
Contributor

chenchun commented Mar 8, 2014

@martint, thanks for review the pull request. I have signed the Contributor License Agreement.

@martint

This comment has been minimized.

Copy link
Collaborator

martint commented Mar 10, 2014

Rebased and pushed. I adjusted the commit message a bit and added a unit test, too.

Thanks!

@martint martint closed this Mar 10, 2014

@SWaiter

This comment has been minimized.

Copy link

SWaiter commented Dec 5, 2017

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment