Get PrestoS3FileSystem to work with the AWS Default Credentials Provider #13858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaygeorge
approved these changes
Dec 17, 2019
| throws Exception | ||
| { | ||
| Configuration config = new Configuration(); | ||
| config.setBoolean(S3_USE_INSTANCE_CREDENTIALS, false); | ||
|
|
||
| try (PrestoS3FileSystem fs = new PrestoS3FileSystem()) { | ||
| fs.initialize(new URI("s3n://test-bucket/"), config); | ||
| assertInstanceOf(getAwsCredentialsProvider(fs), DefaultAWSCredentialsProviderChain.class); |
There was a problem hiding this comment.
seems like you could an
assertEquals(getAwsCredentialsProvider(fs), DefaultAWSCredentialsProviderChain.getInstance())
which is better than assertInstanceOf
There was a problem hiding this comment.
I recommend keeping this, since this is more descriptive and the DefaultAWSCredentialsProviderChain class is a stronger contract than the instance.
|
@anoopj |
@ajaygeorge I will change the commit message headline. |
DefaultAWSCredentialsProviderChain is frequently used by AWS customers and it provides access from a documented list of sources. This especially makes it easier to run Presto on non-EC2 hosts where you don't have the instance profile. (e.g. Macs, during development). See: https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/auth/DefaultAWSCredentialsProviderChain.html
anoopj
force-pushed
the
anoopj/default-aws-creds
branch
from
7265aad
to
4c3a147
Compare
arhimondr
approved these changes
Dec 26, 2019
7 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultAWSCredentialsProviderChain is frequently used by AWS customers
and it provides access from a documented list of sources. This
especially makes it easier to run Presto on non-EC2 hosts where you
don't have the instance profile. (e.g. Macs, during development).
See:
https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/auth/DefaultAWSCredentialsProviderChain.html
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.