Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sheet Connector #16721

Merged
merged 1 commit into from Nov 24, 2021
Merged

Google Sheet Connector #16721

merged 1 commit into from Nov 24, 2021

Conversation

chliang71
Copy link
Contributor

@chliang71 chliang71 commented Sep 9, 2021

Trino has introduced google sheet connector in this PR.

Note that currently Trino google sheet connector only supports read queries, and doesn't support inserts.

This open WIP PR in Trino attempts to add insert functionality. I plan to follow up in next PR.

Related ticket #16516

== RELEASE NOTES ==

General Changes
* Introduce Google sheet connector, supporting read queries

@chliang71 chliang71 closed this Sep 9, 2021
@chliang71 chliang71 reopened this Sep 9, 2021
@v-jizhang
Copy link
Contributor

@v-jizhang v-jizhang commented Sep 10, 2021

@chliang71 Could you add Co-authors? Thanks

@chliang71
Copy link
Contributor Author

@chliang71 chliang71 commented Sep 10, 2021

@chliang71 Could you add Co-authors? Thanks

Thanks for the catch, added co-author and the Trino PR to the commit message

@rohanpednekar
Copy link

@rohanpednekar rohanpednekar commented Sep 17, 2021

Hi @xumingming, hope you are doing good. Do you think you can review this PR? Thanks!

@chliang71
Copy link
Contributor Author

@chliang71 chliang71 commented Oct 21, 2021

Friendly ping @xumingming @tdcmeehan mind reviewing this PR? Thanks!

@beinan beinan self-requested a review Nov 4, 2021
Copy link
Member

@beinan beinan left a comment

Hey @chliang71, it's really a great feature, thanks a lot for your contribution! generally it looks good to me. But the credential file path is hard coded which break the tests. could you fix it?

</dependency>
</dependencies>

</project>
Copy link
Member

@beinan beinan Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line at the end

Copy link
Member

@beinan beinan Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @chliang71, I think we need a new-line at the end of this pom file just like other connectors.

public class TestSheetsPlugin
{
//static final String TEST_METADATA_SHEET_ID = "1Es4HhWALUQjoa-bQh4a8B5HROz7dpGMfq_HbfoaW5LM#Tables";
static final String TEST_METADATA_SHEET_ID = "1qDMzfuAFE60h2_kKrPwz0S-oaJ23Gy9iGBHZZbulY1o#Tables";
Copy link
Member

@beinan beinan Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this sheet id coming from? is it a sheet to public?

Copy link
Contributor Author

@chliang71 chliang71 Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a public sheet that was created to test this from Trino. I'm reusing the sheet. In production though, users should create their own metadata sheet with right permissioms.

@@ -0,0 +1 @@
ewogICJ0eXBlIjogInNlcnZpY2VfYWNjb3VudCIsCiAgInByb2plY3RfaWQiOiAicHJlc3RvdGVzdCIsCiAgInByaXZhdGVfa2V5X2lkIjogIjgwN2M3OTBiZjAwNTY1Mzg1NGMxMzNjMTU3MTAwNzc0NGNiYjYwZTUiLAogICJwcml2YXRlX2tleSI6ICItLS0tLUJFR0lOIFBSSVZBVEUgS0VZLS0tLS1cbk1JSUV2UUlCQURBTkJna3Foa2lHOXcwQkFRRUZBQVNDQktjd2dnU2pBZ0VBQW9JQkFRQ2phY004WWNJZlc4cWJcbkFpczFobGV5L3h5cUgxdkVlMmxtb1NtZ2NpKzdJcFc4ZXZWdnZJM0VzRzJiNldyRU5rcTRIYVdiUzkvZ1JmQUJcbk9kRithdkJxK1pUZEZlTm5RWnk2NWNOekRMQk5kYmJKbHNON0lCQ3hGSnE5YXNRUFhCMGh4blZXdXhPelFYTUJcbm5DNk83MTVzODRSVitjYUVuaFRIZ2dvMm9uczdkSUNNeUhDOVpMK0ZTN1AvZHN4Yms2MitrU24yTm8rUEFqTVRcbkdtcHRnanM1c0kxaTZqQ3h1WFdCU0pUaW41S0ZGbm1CaTR4U2dSNVBqN2Q3cm9Ja0JMSTVqNWFGeGhNWC9JUmNcblpuSCtEUXlTMTgwblBZaUZZUjIyT3JzWTlkVSt1K3JMOXNwSFhhenU2RElhS2QwY3ZnSnlWYmxRVk5Zc2gvUmxcbjB0ekU0bnRQQWdNQkFBRUNnZ0VBREZoV0ZuNndJcHhWbndZMzYzQTl1ZGtKK2xRcUk1ckxLS1N1TjEvSStWTXdcbmlxK2pVUkNtaVNCbTkydFgxSURoZmkxSE1JYzMzNEtKRWg2akUvRFNQdEtpQzEyMjh6c0NzeC9lZHhlVFRoYkJcbmUxTTNhMXJOeUFMdGViZlNIZkx3aEhld3I1K3NhbE5jYzlldnNMNm1uSVo5RGQyendKc01xTkhMSWJ0K29jd1pcbmFYcFVocTBnSlhGUUowY1hPeUdPUHdwTnVvMTFPVEw3K1lTQlJQMmJ4WXo2aFl1dUM5QXBLT2RZWGtyeTl5T2JcbkhXczN5U0plME5HWGhGL3VjeDBQRldqdlV5WDhoM3JaSTV0Z1J5NldEQ0RFcTJHUmMwQUZsZlFXRHIzbEtpVUhcbmdzMnNtLzVaWmRhdDVLSE02Z0pUL3F3WjVPNHhOelEzS1l2T2k1citRUUtCZ1FEVUpaTko1MSsyeEFaMzFnYTdcblZHODNOcmdGNCtaVXBwSlpMYzhMc0l5dzAyTkcxMmVSZmF5bExaOHpqL1oxc0xVR0JVUjY1dWJKai92cEtsc0ZcbkE0bUY1bFdQM21BbU5XblNhdUN5THVzU1ZzdmNabW9xM0Q2U3hsK0UzSms3VHY3UlF4RTJRUm1BVHlqY2xKQjBcbkk5WndRd1JLYkY3d2lUWnM2TDdTakZRNUlRS0JnUURGTVVwMFpWRW4ybUJNYXo5dmxvbEZpSmhxZ09lSkd6UENcblNwMWpVSHdZQkIrcW4wQjFXTnJEV0ZkQmZZSlJ1SldwYWc5RUV4L2tZVDVFQVFDY3FtaU1iSFZtSnVRT0FVUnVcblNacWxERUhSSkhwWVF5cUFHMVNucitsN2V1Q3FSaFF4RWVqNE1wVER6Z1ZiM1o2MUpXbGF6cEhoMVRnNnJNOXFcbmk0N0pkbmoyYndLQmdRRFFzakpGOXFZeTduNEtiM0xwNERNVVZ2RUxZbG5aRnBCTHlJT3cxVHBpVFdHUmRCLy9cbmdXbFFpU1BmSHBWdXk2b1pSUjlMNUZCUEl5VEhDSkxIeU9ZRjRrUnpwbWhoemhQUEdyTDJ0cThydUZVTitYWWhcbnVjNllweXVhVVVVd2toS2RHK1FYd2t6cTYzU2dJa3BFNW1oeXdZcThDQVlSakhvTkE1Mk5GTjFaNFFLQmdBRlBcbkVYSnlWYmFSQVlDZ1daeHhBRnBBek5vd0h0bFBIK25UT3ZZMHk0NFJRUENOL0F5TFdYQmdmcnZGakg3a1hjSHhcbkhVYlRaYXZMWlhGb0hFdnQ2YUc4K282Q0JaTitPS2tPdmdNSWNNdGxsWlpPWTlMVDI1ejlVdXhwNVdIYjh6aGNcbktSSzBxejRkZVBXaUkvS0ozQWdwUk5pZDVMQ25BdjF2RGJTU243enJBb0dBV3lJMWJBWWoyTjJHVHFvQ1ovdmhcbjhIeWdrYVY1TGxZQlBpTVd5YzM0cW5MUmFIamxFc2FTZVRVcWxBUFp1UTB2Umk1NXpDZzJXWFAzOHYvNjk4ekxcbi9meXFZM2ZpY2hNV05SVzRrbWRCdWJPQWdKbFJmOFp3cDJPd1JicVgwU3FtWkVjc3I4ekNISysvN1huMTRzWGpcbkdzbGVRNnpFU05sNkk3RjFXOW02a0g0PVxuLS0tLS1FTkQgUFJJVkFURSBLRVktLS0tLVxuIiwKICAiY2xpZW50X2VtYWlsIjogInByZXN0b3Rlc3RAcHJlc3RvdGVzdC5pYW0uZ3NlcnZpY2VhY2NvdW50LmNvbSIsCiAgImNsaWVudF9pZCI6ICIxMTY5ODUyMjI4NTIxODQzNzYyOTMiLAogICJhdXRoX3VyaSI6ICJodHRwczovL2FjY291bnRzLmdvb2dsZS5jb20vby9vYXV0aDIvYXV0aCIsCiAgInRva2VuX3VyaSI6ICJodHRwczovL29hdXRoMi5nb29nbGVhcGlzLmNvbS90b2tlbiIsCiAgImF1dGhfcHJvdmlkZXJfeDUwOV9jZXJ0X3VybCI6ICJodHRwczovL3d3dy5nb29nbGVhcGlzLmNvbS9vYXV0aDIvdjEvY2VydHMiLAogICJjbGllbnRfeDUwOV9jZXJ0X3VybCI6ICJodHRwczovL3d3dy5nb29nbGVhcGlzLmNvbS9yb2JvdC92MS9tZXRhZGF0YS94NTA5L3ByZXN0b3Rlc3QlNDBwcmVzdG90ZXN0LmlhbS5nc2VydmljZWFjY291bnQuY29tIgp9
Copy link
Member

@beinan beinan Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an account for this credential? who is the owner of this credential?

Copy link
Contributor Author

@chliang71 chliang71 Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the credential for that public testing sheet, it is an encrypted credential. Not sure about the owner, but most likely @punit.kj from the Trinodb PR. This is just for testing.

Copy link
Member

@beinan beinan Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, can we create a new one or reuse the credential of the big-query connector (if there is one)? Thanks!

Copy link
Member

@beinan beinan left a comment

Also could you update the commit message following the pattern below? thanks!

Fix OOM caused by foo in bar

Foo was pack ratting ByteBuffers causing OOM.

Cherry-pick of https://github.com/foo/bar/pull/123 (https://github.com/foo/bar/pull/123)

Co-authored-by: Foo Bar <foo@bar.com>

@beinan
Copy link
Member

@beinan beinan commented Nov 4, 2021

@ChunxuTang could you also take a look? I think this connector is also great for twitter's use case. Thanks!

Copy link
Contributor

@ChunxuTang ChunxuTang left a comment

@beinan Sure, I'm glad to help with a review! This feature looks nice to Twitter.

@chliang71 Thanks so much for your nice work! I left some comments, mainly concentrating on coding styles. Moreover, as this is a new connector, could you create a document and add it to the presto-docs folder?
Thanks! Looking forward to deploying this feature in Twitter!

@chliang71 chliang71 force-pushed the chliang-gsheet branch 2 times, most recently from 20ccff7 to f7df421 Compare Nov 5, 2021
Copy link
Member

@beinan beinan left a comment

@chliang71 could you rebase master? Thank you! looks like there is a git conflict

@@ -0,0 +1 @@
ewogICJ0eXBlIjogInNlcnZpY2VfYWNjb3VudCIsCiAgInByb2plY3RfaWQiOiAicHJlc3RvdGVzdCIsCiAgInByaXZhdGVfa2V5X2lkIjogIjgwN2M3OTBiZjAwNTY1Mzg1NGMxMzNjMTU3MTAwNzc0NGNiYjYwZTUiLAogICJwcml2YXRlX2tleSI6ICItLS0tLUJFR0lOIFBSSVZBVEUgS0VZLS0tLS1cbk1JSUV2UUlCQURBTkJna3Foa2lHOXcwQkFRRUZBQVNDQktjd2dnU2pBZ0VBQW9JQkFRQ2phY004WWNJZlc4cWJcbkFpczFobGV5L3h5cUgxdkVlMmxtb1NtZ2NpKzdJcFc4ZXZWdnZJM0VzRzJiNldyRU5rcTRIYVdiUzkvZ1JmQUJcbk9kRithdkJxK1pUZEZlTm5RWnk2NWNOekRMQk5kYmJKbHNON0lCQ3hGSnE5YXNRUFhCMGh4blZXdXhPelFYTUJcbm5DNk83MTVzODRSVitjYUVuaFRIZ2dvMm9uczdkSUNNeUhDOVpMK0ZTN1AvZHN4Yms2MitrU24yTm8rUEFqTVRcbkdtcHRnanM1c0kxaTZqQ3h1WFdCU0pUaW41S0ZGbm1CaTR4U2dSNVBqN2Q3cm9Ja0JMSTVqNWFGeGhNWC9JUmNcblpuSCtEUXlTMTgwblBZaUZZUjIyT3JzWTlkVSt1K3JMOXNwSFhhenU2RElhS2QwY3ZnSnlWYmxRVk5Zc2gvUmxcbjB0ekU0bnRQQWdNQkFBRUNnZ0VBREZoV0ZuNndJcHhWbndZMzYzQTl1ZGtKK2xRcUk1ckxLS1N1TjEvSStWTXdcbmlxK2pVUkNtaVNCbTkydFgxSURoZmkxSE1JYzMzNEtKRWg2akUvRFNQdEtpQzEyMjh6c0NzeC9lZHhlVFRoYkJcbmUxTTNhMXJOeUFMdGViZlNIZkx3aEhld3I1K3NhbE5jYzlldnNMNm1uSVo5RGQyendKc01xTkhMSWJ0K29jd1pcbmFYcFVocTBnSlhGUUowY1hPeUdPUHdwTnVvMTFPVEw3K1lTQlJQMmJ4WXo2aFl1dUM5QXBLT2RZWGtyeTl5T2JcbkhXczN5U0plME5HWGhGL3VjeDBQRldqdlV5WDhoM3JaSTV0Z1J5NldEQ0RFcTJHUmMwQUZsZlFXRHIzbEtpVUhcbmdzMnNtLzVaWmRhdDVLSE02Z0pUL3F3WjVPNHhOelEzS1l2T2k1citRUUtCZ1FEVUpaTko1MSsyeEFaMzFnYTdcblZHODNOcmdGNCtaVXBwSlpMYzhMc0l5dzAyTkcxMmVSZmF5bExaOHpqL1oxc0xVR0JVUjY1dWJKai92cEtsc0ZcbkE0bUY1bFdQM21BbU5XblNhdUN5THVzU1ZzdmNabW9xM0Q2U3hsK0UzSms3VHY3UlF4RTJRUm1BVHlqY2xKQjBcbkk5WndRd1JLYkY3d2lUWnM2TDdTakZRNUlRS0JnUURGTVVwMFpWRW4ybUJNYXo5dmxvbEZpSmhxZ09lSkd6UENcblNwMWpVSHdZQkIrcW4wQjFXTnJEV0ZkQmZZSlJ1SldwYWc5RUV4L2tZVDVFQVFDY3FtaU1iSFZtSnVRT0FVUnVcblNacWxERUhSSkhwWVF5cUFHMVNucitsN2V1Q3FSaFF4RWVqNE1wVER6Z1ZiM1o2MUpXbGF6cEhoMVRnNnJNOXFcbmk0N0pkbmoyYndLQmdRRFFzakpGOXFZeTduNEtiM0xwNERNVVZ2RUxZbG5aRnBCTHlJT3cxVHBpVFdHUmRCLy9cbmdXbFFpU1BmSHBWdXk2b1pSUjlMNUZCUEl5VEhDSkxIeU9ZRjRrUnpwbWhoemhQUEdyTDJ0cThydUZVTitYWWhcbnVjNllweXVhVVVVd2toS2RHK1FYd2t6cTYzU2dJa3BFNW1oeXdZcThDQVlSakhvTkE1Mk5GTjFaNFFLQmdBRlBcbkVYSnlWYmFSQVlDZ1daeHhBRnBBek5vd0h0bFBIK25UT3ZZMHk0NFJRUENOL0F5TFdYQmdmcnZGakg3a1hjSHhcbkhVYlRaYXZMWlhGb0hFdnQ2YUc4K282Q0JaTitPS2tPdmdNSWNNdGxsWlpPWTlMVDI1ejlVdXhwNVdIYjh6aGNcbktSSzBxejRkZVBXaUkvS0ozQWdwUk5pZDVMQ25BdjF2RGJTU243enJBb0dBV3lJMWJBWWoyTjJHVHFvQ1ovdmhcbjhIeWdrYVY1TGxZQlBpTVd5YzM0cW5MUmFIamxFc2FTZVRVcWxBUFp1UTB2Umk1NXpDZzJXWFAzOHYvNjk4ekxcbi9meXFZM2ZpY2hNV05SVzRrbWRCdWJPQWdKbFJmOFp3cDJPd1JicVgwU3FtWkVjc3I4ekNISysvN1huMTRzWGpcbkdzbGVRNnpFU05sNkk3RjFXOW02a0g0PVxuLS0tLS1FTkQgUFJJVkFURSBLRVktLS0tLVxuIiwKICAiY2xpZW50X2VtYWlsIjogInByZXN0b3Rlc3RAcHJlc3RvdGVzdC5pYW0uZ3NlcnZpY2VhY2NvdW50LmNvbSIsCiAgImNsaWVudF9pZCI6ICIxMTY5ODUyMjI4NTIxODQzNzYyOTMiLAogICJhdXRoX3VyaSI6ICJodHRwczovL2FjY291bnRzLmdvb2dsZS5jb20vby9vYXV0aDIvYXV0aCIsCiAgInRva2VuX3VyaSI6ICJodHRwczovL29hdXRoMi5nb29nbGVhcGlzLmNvbS90b2tlbiIsCiAgImF1dGhfcHJvdmlkZXJfeDUwOV9jZXJ0X3VybCI6ICJodHRwczovL3d3dy5nb29nbGVhcGlzLmNvbS9vYXV0aDIvdjEvY2VydHMiLAogICJjbGllbnRfeDUwOV9jZXJ0X3VybCI6ICJodHRwczovL3d3dy5nb29nbGVhcGlzLmNvbS9yb2JvdC92MS9tZXRhZGF0YS94NTA5L3ByZXN0b3Rlc3QlNDBwcmVzdG90ZXN0LmlhbS5nc2VydmljZWFjY291bnQuY29tIgp9
Copy link
Member

@beinan beinan Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, can we create a new one or reuse the credential of the big-query connector (if there is one)? Thanks!

Copy link
Contributor

@ChunxuTang ChunxuTang left a comment

@chliang71
Reviewed the PR again for the docs. The documentation looks great to me!

@chliang71
Copy link
Contributor Author

@chliang71 chliang71 commented Nov 8, 2021

Thanks for the reviews!! @beinan @ChunxuTang . I have rebased to the master, and have updated the commit message. Please let me know if any other comments.

Copy link
Member

@beinan beinan left a comment

my concern is still the credential stored in presto-google-sheets/src/test/resources/gsheets-creds-base64-encoded.props. I think the owner of this credential is prestosqltest@gmail.com. Also there is a rate limit on this credential, not sure if it will cause any issue if we're this one for the both two presto projects. can we create a new credential under prestodbtest@gmail.com? I can share you the password of this google account offline if you need it.

@chliang71
Copy link
Contributor Author

@chliang71 chliang71 commented Nov 9, 2021

my concern is still the credential stored in presto-google-sheets/src/test/resources/gsheets-creds-base64-encoded.props. I think the owner of this credential is prestosqltest@gmail.com. Also there is a rate limit on this credential, not sure if it will cause any issue if we're this one for the both two presto projects. can we create a new credential under prestodbtest@gmail.com? I can share you the password of this google account offline if you need it.

If there is another more fitting credential to use then definitely we can go for it. Thanks.

@chliang71 chliang71 force-pushed the chliang-gsheet branch 2 times, most recently from 08043c1 to 8424e38 Compare Nov 10, 2021
@chliang71
Copy link
Contributor Author

@chliang71 chliang71 commented Nov 11, 2021

@beinan I have updated to use the prestodbtest account, and have recreated the metadata sheet for presto db. Please take a look when you get a chance. Thanks!!

Copy link
Member

@beinan beinan left a comment

Looks good to me except we should add a new-line at the end of the pom file you newly added.

Also, could you refine the commit message a little bit as https://chris.beams.io/posts/git-commit/ suggested? thanks!

</dependency>
</dependencies>

</project>
Copy link
Member

@beinan beinan Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @chliang71, I think we need a new-line at the end of this pom file just like other connectors.

@chliang71 chliang71 force-pushed the chliang-gsheet branch 3 times, most recently from 3cdbaea to 137590a Compare Nov 24, 2021
@chliang71
Copy link
Contributor Author

@chliang71 chliang71 commented Nov 24, 2021

Thanks for the review @beinan !! I have updated the PR (commit message and pom). But for some reason, although my local build worked fine, the maven check is failing... Please let me know if other changes needed. Thanks!

beinan
beinan approved these changes Nov 24, 2021
Copy link
Member

@beinan beinan left a comment

lgtm, I will rerun the ci

@beinan
Copy link
Member

@beinan beinan commented Nov 24, 2021

Thanks for the review @beinan !! I have updated the PR (commit message and pom). But for some reason, although my local build worked fine, the maven check is failing... Please let me know if other changes needed. Thanks!

I see, the current version is '0.267-SNAPSHOT' but the pom you just added is still on 0.266-SNAPSHOT

Non-resolvable parent POM for com.facebook.presto:presto-google-sheets:0.266-SNAPSHOT: Could not find artifact com.facebook.presto:presto-root:pom:0.266-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 5, column 13 -> [Help 2]

@chliang71 could you please rebase and update the version? Thanks!

This change introduces Google sheet connector. This change is largely cherry-picked from TrinoDB (trino#1030) and rebased into Presto. Please note that this change introduces only the query/read functionality of data from existing Google sheets, and does not currently support insert/write into Google sheets.

cherry-pick of trinodb/trino#1030

Co-authored-by: Puneet Jaiswal <punit.kj@gmail.com>
@chliang71
Copy link
Contributor Author

@chliang71 chliang71 commented Nov 24, 2021

Thanks for checking @beinan , good catch! I updated the pom to 267, now the majority of the checks are passing. But still two test failures

TestDistributedQueuesDb.testDistributedQueue_burstTraffic
TestBrutalShutdown.testQueryRetryOnShutdown

But I don't see how these two tests can be related to my change... also, when I ran these two tests locally, they both passed.

@beinan
Copy link
Member

@beinan beinan commented Nov 24, 2021

Thanks for checking @beinan , good catch! I updated the pom to 267, now the majority of the checks are passing. But still two test failures

TestDistributedQueuesDb.testDistributedQueue_burstTraffic
TestBrutalShutdown.testQueryRetryOnShutdown

But I don't see how these two tests can be related to my change... also, when I ran these two tests locally, they both passed.

rerun the ci, let's wait and see

@beinan beinan merged commit 71f3788 into prestodb:master Nov 24, 2021
40 checks passed
@varungajjala
Copy link
Contributor

@varungajjala varungajjala commented Nov 29, 2021

@beinan We are seeing some unit test failures.

"Expected exception message 'Failed reading data from sheet: 1fu6qjHrOARa7Rqezfgd9C--XPCUOkN_vhvwpxZ4INGE#Tables' to match 'Sheet expression not found for table foo_bar_table' for query: select * from gsheets.default.foo_bar_table" is a sample error message. Can you please take a look and fix them. Builds are broken due to this.

@beinan
Copy link
Member

@beinan beinan commented Dec 1, 2021

@varungajjala Sure, is this one just flaky or failed all the time?

@chliang71 could you also help? thanks!

@beinan
Copy link
Member

@beinan beinan commented Dec 1, 2021

@varungajjala I just posted a pr to disable the test: #17052

Looks like these tests are visiting the google service via internet, which I guess would make the test very flaky in poor network environment. I think we could not re-enable these test until we're able to mock the google sheet service. @chliang71 what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants