New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature prune join output #6465

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@sopel39
Member

sopel39 commented Oct 28, 2016

FYI: @martint @dain

Partial micro benchmark results:

    Partial results:
    Benchmark                                             (buildHashEnabled)  (hashColumns)  (matchRate)  (outputColumns)  Mode  Cnt    Score   Error  Units
    BenchmarkHashBuildAndJoinOperators.benchmarkJoinHash                true         bigint            2          varchar  avgt   60  157,080 ± 3,820  ms/op
    BenchmarkHashBuildAndJoinOperators.benchmarkJoinHash                true         bigint            2           bigint  avgt   60   90,912 ± 1,954  ms/op
    BenchmarkHashBuildAndJoinOperators.benchmarkJoinHash                true         bigint            2              all  avgt   60  203,645 ± 3,665  ms/op

all is a baseline. When you require just some columns the join time reduces significantly.

@@ -307,13 +307,18 @@ private PagesIndexOrdering createPagesIndexComparator(List<Integer> sortChannels
public Supplier<LookupSource> createLookupSourceSupplier(Session session, List<Integer> joinChannels)
{
return createLookupSourceSupplier(session, joinChannels, Optional.empty(), Optional.empty());

This comment has been minimized.

@pnowojski

pnowojski Oct 28, 2016

Member

outout typo in commit message

@pnowojski

pnowojski Oct 28, 2016

Member

outout typo in commit message

Show outdated Hide outdated ...ava/com/facebook/presto/operator/BenchmarkHashBuildAndJoinOperators.java Outdated
Show outdated Hide outdated .../facebook/presto/sql/planner/optimizations/PruneUnreferencedOutputs.java Outdated
@pnowojski

This comment has been minimized.

Show comment
Hide comment
@pnowojski

pnowojski Oct 28, 2016

Member

This will probably conflict with #6395

Member

pnowojski commented Oct 28, 2016

This will probably conflict with #6395

sopel39 added some commits Oct 25, 2016

Add output channels selection to BenchmarkHashBuildAndJoinOperators
Partial results:
Benchmark                                             (buildHashEnabled)  (hashColumns)  (matchRate)  (outputColumns)  Mode  Cnt    Score   Error  Units
BenchmarkHashBuildAndJoinOperators.benchmarkJoinHash                true         bigint            2          varchar  avgt   60  157,080 ± 3,820  ms/op
BenchmarkHashBuildAndJoinOperators.benchmarkJoinHash                true         bigint            2           bigint  avgt   60   90,912 ± 1,954  ms/op
BenchmarkHashBuildAndJoinOperators.benchmarkJoinHash                true         bigint            2              all  avgt   60  203,645 ± 3,665  ms/op

@sopel39 sopel39 closed this Nov 2, 2016

@sopel39 sopel39 deleted the Teradata:feature_prune_join_output branch Nov 2, 2016

@sopel39 sopel39 restored the Teradata:feature_prune_join_output branch Nov 2, 2016

@sopel39

This comment has been minimized.

Show comment
Hide comment
@sopel39

sopel39 Nov 2, 2016

Member

reopening

Member

sopel39 commented Nov 2, 2016

reopening

@sopel39 sopel39 referenced this pull request Nov 2, 2016

Closed

Feature prune join output #6501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment