Change LOWEST_MAX_STANDARD_ERROR for approx_distinct function #9397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
approved these changes
Nov 22, 2017
Contributor
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Looks good, but change the commit message to say: "Reduce lowest standard error for approx_distinct".
Contributor
Author
|
Thanks for the review! I think it should be "lowest max standard error" :) |
Contributor
|
No, the "max" in the names of those constants is wrong. It's not an upper bound on the error. It's a "standard error" (i.e., the standard deviation of the distribution of possible errors). So, this changing the "lowest standard error the function can operate with". I.e., there's not such a thing as a "max standard error". |
Maximum number of buckets in HyperLogLog changed from 8192 to 65536, so now we could support lower max standard errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maximum number of buckets in HyperLogLog changed from 8192 to 65536,
so now we could support lower max standard errors.