Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Hive 3.0.0 #2

Merged
merged 1 commit into from Feb 11, 2019

Conversation

3 participants
@electrum
Copy link
Member

electrum commented Feb 10, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 10, 2019

@electrum electrum requested a review from dain Feb 11, 2019

@electrum electrum referenced this pull request Feb 11, 2019

Merged

Update to Hive 3.0.0 #203

@@ -1,191 +0,0 @@
/**

This comment has been minimized.

@findepi

findepi Feb 11, 2019

Member

❤️

This comment has been minimized.

@electrum

electrum Feb 11, 2019

Author Member

👍 They merged your changes

if (columnNameProperty.length() == 0) {
columnNames = new ArrayList<String>();
if (columnNameProperty.isEmpty()) {
columnNames = Collections.emptyList();

This comment has been minimized.

@findepi

findepi Feb 11, 2019

Member

any other copied classes need update?

This comment has been minimized.

@electrum

electrum Feb 11, 2019

Author Member

Yes, I verified the others (most are shims and not copied classes)

@@ -43,14 +43,13 @@

<shadeBase>io.prestosql.hive.\$internal</shadeBase>

<dep.hive.version>2.3.4</dep.hive.version>
<dep.hive.version>3.0.0</dep.hive.version>

This comment has been minimized.

@findepi

findepi Feb 11, 2019

Member

I expect that Hive 3.0 is not an interesting version. Everybody who upgrades to Hive 3 will probably upgrade to 3.1.
I am ok with upgrading to 3.0 if

  • we later upgrade to 3.1
  • or we realize that my expectations do not match real world

This comment has been minimized.

@findepi

This comment has been minimized.

@electrum

electrum Feb 11, 2019

Author Member

I agree, it's not interesting. This is to update the Parquet version since the one in 2.3.4 is broken.

@dain

dain approved these changes Feb 11, 2019

@electrum electrum merged commit 21b4035 into prestosql:master Feb 11, 2019

1 check passed

verification/cla-signed
Details

@electrum electrum deleted the electrum:update30 branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.