Refactor dynamic filters #4262
Merged
Refactor dynamic filters #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
force-pushed
the
ks/dyn_filters_refactors
branch
2 times, most recently
from
7ab4497
to
0b589c7
Compare
sopel39
force-pushed
the
ks/dyn_filters_refactors
branch
5 times, most recently
from
e695dcb
to
72c0d44
Compare
sopel39
force-pushed
the
ks/dyn_filters_refactors
branch
from
72c0d44
to
68f525e
Compare
martint
approved these changes
Jul 3, 2020
| @@ -106,7 +106,7 @@ public void registerQuery(SqlQueryExecution sqlQueryExecution) | |||
| @VisibleForTesting | |||
| synchronized void registerQuery(QueryId queryId, Supplier<List<StageDynamicFilters>> stageDynamicFiltersSupplier, Set<SourceDescriptor> dynamicFilters) | |||
| { | |||
| dynamicFilterSuppliers.putIfAbsent(queryId, stageDynamicFiltersSupplier); | |||
| dynamicFilterSuppliers.put(queryId, stageDynamicFiltersSupplier); | |||
There was a problem hiding this comment.
It was inconsistent with other put for queryDynamicFilters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.