tablesample handling code cleanup #5074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
approved these changes
Sep 3, 2020
| }); | ||
|
|
||
| if (!(samplePercentageObject instanceof Number)) { | ||
| throw semanticException(TYPE_MISMATCH, relation.getSamplePercentage(), "Sample percentage should evaluate to a numeric expression"); | ||
| ResolvedFunction coercion = metadata.getCoercion(samplePercentageType, DOUBLE); |
There was a problem hiding this comment.
This is only needed if samplePercentageType != DOUBLE
There was a problem hiding this comment.
Also, this could be done after checking whether the value is null, in which case, you don't need a separate variable for samplePercentageObject. An implicit cast should never produce a null from a non-null value.
There was a problem hiding this comment.
An implicit cast should never produce a null from a non-null value.
I thought about this, but i didn't want to put this assumption in the code,
on the assumption that less assumptions the easier to read...
i will rearange if you find this more useful that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.